アイコンライブラリ導入によるSVGハードコード除去#33
Merged
Merged
Conversation
ktmage
added a commit
that referenced
this pull request
Mar 1, 2026
ktmage
added a commit
that referenced
this pull request
Mar 1, 2026
THIRD_PARTY_NOTICES.md に react-icons (VS Code Icons subset) のライセンスを追加。 CHANGELOG の Unreleased に Keyboard navigation for inline popups と SVG アイコン置換を追記。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ハードコードされた約35個のSVGアイコンを
react-icons/vsc（VS Code Codicons）に置き換え、保守性を向上させた。Related Issue
#28
Changes
react-iconsパッケージを依存に追加webview/components/atoms/icons/icons.tsxの全アイコンをreact-icons/vscのラッパーに置換（SpinnerIcon のみアニメーション付きカスタムSVGのため維持）Checklist
npm run buildpassesnpm testpasses